Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Venmo to intent filter list in AndroidManifest.xml #3713

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Add Venmo to intent filter list in AndroidManifest.xml #3713

merged 2 commits into from
Jun 21, 2021

Conversation

luacmartins
Copy link
Contributor

cc @chiragsalian

Fixed Issues

Fixes #3692

Tests

  1. Sign-up to Expensify.cash with a US phone number and validate that account (Account A)
  2. Create another account with a different US phone number (Account B) that has the Venmo app installed on their mobile device.
  3. As account A, Complete the request money flow and send a payment request to account B (make sure the IOU report currency is USD).
  4. Log-in as account B and click the pay button
  5. Verify that Pay with Venmo is visible as an option in the dropdown

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Android Screenshots

Screenshot_1624311319
Screenshot_1624311315

@luacmartins luacmartins requested a review from a team June 21, 2021 21:39
@luacmartins luacmartins self-assigned this Jun 21, 2021
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 21, 2021 21:39
@luacmartins luacmartins requested review from marcaaron and a team and removed request for Dal-Papa and marcaaron June 21, 2021 21:45
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 21, 2021 21:57
@luacmartins luacmartins requested review from a team and removed request for Dal-Papa June 21, 2021 21:59
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 21, 2021 22:00
@luacmartins luacmartins requested a review from a team June 21, 2021 22:00
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team June 21, 2021 22:00
@luacmartins luacmartins requested review from AndrewGable and removed request for Dal-Papa and TomatoToaster June 21, 2021 22:01
@luacmartins luacmartins requested a review from a team as a code owner June 21, 2021 22:22
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team June 21, 2021 22:22
@luacmartins luacmartins removed the request for review from Jag96 June 21, 2021 22:23
@luacmartins
Copy link
Contributor Author

Self merging after all tests passed.

@luacmartins luacmartins merged commit 4de0c44 into main Jun 21, 2021
@luacmartins luacmartins deleted the cmartins-android-add-venmo-support branch June 21, 2021 22:59
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 22, 2021
Closed
@luacmartins luacmartins mentioned this pull request Jun 22, 2021
Closed
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

github-actions bot pushed a commit that referenced this pull request Jun 22, 2021
@luacmartins
Merge pull request #3713 from Expensify/cmartins-android-add-venmo-su…
d9413ff 
…pport

Add Venmo to intent filter list in AndroidManifest.xml

(cherry picked from commit 4de0c44)
@OSBotify OSBotify mentioned this pull request Jun 22, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.73-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jun 25, 2021
Closed
72 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jun 29, 2021
Closed
22 tasks
This was referenced Jul 7, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android - Payment -Missing the dropdown for payment option, so Pay with Venmo isn't visible
3 participants
@luacmartins @OSBotify @AndrewGable